Commit Graph

4165 Commits

Author SHA1 Message Date
Leah Rowe 77b0b448e2 more cleanup
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 19:37:57 +01:00
Leah Rowe c7fb6a2bc8 get.sh: remove redundant check
we don't pull anything from supermicro's site.
we did briefly, in an earlier port for that
one supermicro board.

don't maintain dead code. dead code has one purpose:
be deleted.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 18:12:36 +01:00
Leah Rowe 2d1d7624e9 get.sh: add try_fetch_copy function
just a skeleton that calls the curl function

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 15:10:44 +01:00
Leah Rowe a32374f6cc more cleanup
this will be the last time, i promise

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 14:29:11 +01:00
Leah Rowe 897c2667af get.sh: even more cleanup (simplified fetch)
fetch_submodule now contains just the right amount
of eval, which means all of the eval.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 13:24:13 +01:00
Leah Rowe 446eca846e get.sh: further cleanup
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 12:49:12 +01:00
Leah Rowe c3e2d8c8bc get.sh: simplify xbget
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 11:19:42 +01:00
Leah Rowe b094c60a39 more variable cleanup
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 09:02:04 +01:00
Leah Rowe 798cc79399 mk: export locales much earlier
also simplify the way it works (eval and awk)

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-12 08:49:53 +01:00
Leah Rowe 6a2e9a7919 remove include/chromebook.sh import script (not needed)
i will be adding chromebooks, but not using this script,
which is why i never finished the script. i previously
had the plan to patch upstream coreboot, by importing
patches from mrchromebox, but that results in an extreme
number of patches. several hundred patches, in fact.

more efficient is to add multi-upstream support in
include/get.sh, for using different upstreams including
forks, on a given multi-tree project. i haven't done
this yet, but this is what will be done, and then
adding each chromebook will be a matter of importing
configs from mrchromebox alongside edk2 integration.

a script will still need to be written, for the initial
import, and imported chromebooks will be set release=n
until and when each target is fully tested.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 21:51:00 +01:00
Leah Rowe d0a1b40910 more cleanup
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 21:43:50 +01:00
Leah Rowe 0fd3d72998 tree.sh: remove redundant TODO
infinite loop detection was here before. i removed it
because it was bloat. we don't take general user input
here, so careful configuration is all we need.

infinite loops are harmless to the user. they are merely
annoying. they would never be introduced to the user,
because configs are always tested before release.
before commit, even.

we can save the user a few watts of electricity, or we
can Keep It Simple.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:49:26 +01:00
Leah Rowe 425855899f rom.sh: remove another TODO
this one is unnecessary, because we're not taking general input
from the user. we mitigate this carefully by being, you know,
careful.

implementing the TODO would have bloated the code, in ways that
might only introduce other serious bugs.

the current logic is fine, and great care will always be taken
by me to keep the code safe, while i'm in charge.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:46:07 +01:00
Leah Rowe f648167b9f rom.sh: remove redundant TODO
the code is correct. no TODO needed here.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:45:14 +01:00
Leah Rowe 36fef51e8f init.sh: universally set git commit/auth date
do it as an export. to avoid pollution elsewhere,
do it inside a subshell.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:42:03 +01:00
Leah Rowe b6b5f70934 init.sh: set git committer date as well
only the author date was being set before

with this change, at least on my system, i
now get the same commit ID and date each time
on the following test:

NOTE: . is lbmk (main work directory)
NOTE: here, we are copying the current clone

git clone . lbmktest
cd lbmktest
./mk version
rm -Rf .git
./mk version
git log

same output each time. we have thus eliminated
timestamps as a variable. this is but a part of
in a series of changes that will eventually lead
to libreboot being built reproducibly.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:32:12 +01:00
Leah Rowe 58094bd017 init.sh: portable date on git-init
don't even call the date util at all, to fix the
portability issues. now we don't need GNU date
anymore.

git itself can just take an epoch, and it will
do whatever it will do. yes.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:28:15 +01:00
Leah Rowe cdd399017e init.sh: don't check PATH on startup
even if i unset PATH before running lbmk, it is
reinitialised because of the shebang. if no PATH
exists, then it's either a broken system and you
have bigger problems, or you have some weird
system that uses something else.

our job is not to fix the world. there was no
scenario in which this check would even trigger
an error or fallback, so just remove it.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 19:02:20 +01:00
Leah Rowe 15204cda63 xbmk: re-introduce condensed if statements
i've been careful to makely only use it on AND operations,
not onse that use OR. a lot of blocks are not condensed,
unlike previously when this design was used.

i removed the condensed design because it made the code
allegedly easier to read, but i found it harder to read
and found the code looked dirty. this change makes it
clean again, but i've done it in a way where the shorthand
conditional statements are easy to understand for most
people. this strikes a compromise; i would go further.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 16:18:09 +01:00
Leah Rowe 8173aea83b xbmk: reintroduce setvar as newvar (init only)
use the simpler logic recently introduced, generalised
but it only sets variables to empty. this is safer than
the previous design, and brings the same reduction in
sloccount overall since i wasn't doing anything other
than emptying variables anyway, when it was used before.

i didn't like the long list of variables inside files,
so this makes everything more readable.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-11 14:24:55 +01:00
Leah Rowe aad748c5ca inject.sh: simplify xbmkcheck initialisation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 22:49:57 +01:00
Leah Rowe 8db320799b inject.sh: re-order variables
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 22:20:05 +01:00
Leah Rowe 04c3bc53b6 mk: add error exit
not needed at the moment, since we ensure that
the functions always exit with error under fault
condition. they always return zero.

nevertheless, this might catch some unexpected
behaviour in the future.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 20:08:08 +01:00
Leah Rowe d722a02cda mk: remove redundant xrval variable
not needed.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 20:06:46 +01:00
Leah Rowe 6fe1d47fb3 mk: remove redundant set command
we exit immediately afterward, so there's
no point in putting this here.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 20:01:48 +01:00
Leah Rowe 005f1189c1 mk: major code cleanup
we don't need a main here. it's so generic that we
can just leave it really small like it is now. now
it's much clearer what it actually does.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:56:36 +01:00
Leah Rowe 86781a5881 mk: simplified command check
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:43:28 +01:00
Leah Rowe 61ab5723df xbmk: use proper shebang
env isn't that useful these days. better just
use the standard declaration.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:37:16 +01:00
Leah Rowe 6050cdd1db init.sh: much more thorough locale initialisation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:35:17 +01:00
Leah Rowe 8c927b535d update header again
Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:28:27 +01:00
Leah Rowe 5f0bd5ea10 xbmk: remove setvars function
only one file used it. i've replaced its use with
a simple awk call alongside eval.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 19:25:45 +01:00
Leah Rowe 8822c56815 mk: make it completely generic
commands now fed from a file, include/common.sh
which in turn also includes other lib files

this makes mk completely generic, and means
that changes will now be completely in sync
with cbmk, ensuring a lack of merge conflicts,
though the file was already pretty small anyway.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 18:05:57 +01:00
Leah Rowe bb0221252c mk: make xbcddir usage clearer
it's always a directory, so filter it first

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 17:47:48 +01:00
Leah Rowe 1ceeb0ab55 update lbmk headers
i made several modificatinos to several files
thus for in 2026, in the main part of the build system.

i've added 2026 to the ones that i modified.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 17:45:11 +01:00
Leah Rowe bb4c038794 cleanup
actually use xbarg0

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 15:03:03 +01:00
Leah Rowe 786cf8cd9c xbmk: allow to run from PATH
now you can put lbmk somewhere on your system,
and symlink to the mk script from PATH

e.g. /usr/local/bin/lbmk -> /home/leah/lbmk/mk

lbmk will cd to itself, including from PATH,
because the string will then be passed through
readlink, which gets the real path.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 14:03:11 +01:00
Leah Rowe 189b61018f xbmk: allow running from outside of work dir
i need only now implement a check for sys dirs
e.g. /etc/lbmk.cfg and check if it defines
e.g. other location for config/ and include/

then mk is a generic dispatcher and i can one
day make mk possible to install. for example, if
you have a bsd ports system and you want to
install lbmk

i could make it check user dirs too, overriding
defaults. for example /usr/local/etc/lbmk, but
then i might have ~/.config/lbmk

you no longer need to be in the xbmk directory
to run xbmk. it'll cd to itself, with this patch

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 13:52:16 +01:00
Leah Rowe e973584123 mk: generalised dispatch loop
with this new function, i can turn commands on and
off by virtue of config. for now, behaviour is
unchanged, but this new design means i will be
able to disable certain commands in child processes

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 13:49:34 +01:00
Leah Rowe afdf8c7733 Revert "xbmk: general code cleanup"
This reverts commit 1b65e8914c.

NOTE: cleanup of xbmk_git_init was retained

this "cleanup" actually made the code harder to read.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-10 12:34:35 +01:00
Leah Rowe 123639e3db delete util/libreboot-utils (unused code)
this was an intense audit of nvmutil that somehow evolved
into writing a new, hardened implementation of mktemp.

it all works, a few memory bugs to solve on bsd, but i don't
see the point in keeping it. mktemp is fine, and nvmutil
already works.

lbutils implemented atomic writes and integrity checking,
in a manner completely overengineered for what it was
actually doing (modifying a few bytes in 8KB GbE files)

just delete it. i'll bring it back if i ever finish the
code. i don't want to leave dead/unfinished code in the tree.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-07 08:12:24 +01:00
Leah Rowe 01cb422c97 include/get.sh: 3-way merge on git am
this will make managing updates easier. which will
be soon, because i have a lot of patches.

no idea why i didn't add this before. normally, i just
copy a directory and git-fetch, then cherry-pick as
i please. this will make it trivial to just update
a revision and merge the patches. then i can just
intervene only when necessary, on a given src tree.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-09-06 10:16:00 +01:00
Leah Rowe 8d0ad21112 cb/hp820g2_12mb: disable u-boot
it currently boot loops like on some kabylake machines

really buggy codebase. i should just rip off the band-aid
and add edk2 already.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-08-03 23:50:03 +01:00
Leah Rowe d19a0241a1 coreboot/fam15h: fix build error (__unused)
see patch. just some gcc chicanery. nothing to see here.

move along now. yes.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-08-03 22:24:08 +01:00
Leah Rowe 2908904a2f Merge pull request 'remove the --update emerge flag cause it breaks something' (#446) from folkmaster/lbmk:master into master
Reviewed-on: https://codeberg.org/libreboot/lbmk/pulls/446
2026-08-01 01:37:17 +02:00
Leah Rowe 1b65e8914c xbmk: general code cleanup
make the code much easier to read

i also cleaned up the recent git identity check

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-07-30 11:58:11 +01:00
folkmaster 3dd440e1a6 remove the --update emerge flag cause it breaks smth 2026-07-28 13:29:33 +02:00
Leah Rowe 72238d22b5 Merge pull request 'Make emerge ignore rebuilds' (#444) from folkmaster/lbmk:master into master
Reviewed-on: https://codeberg.org/libreboot/lbmk/pulls/444
2026-07-28 03:26:10 +02:00
Leah Rowe d64090d0b2 Merge pull request 'Fix Git identity handling in xbmk_git_init' (#445) from zoomm10/lbmk:fix-git-identity into master
Reviewed-on: https://codeberg.org/libreboot/lbmk/pulls/445
2026-07-28 03:23:41 +02:00
Zoomm Deka ab13b80250 fix git identity handling in xbmk_git_init
Signed-off-by: Zoomm Deka <zoomm10@gmail.com>
2026-07-28 03:02:02 +02:00
Leah Rowe 8b59310209 only disable git check for ./mk -b coreboot
the previous patch was half the battle. now that
annoying person who complained on irc should be
happy.

someone complained about having to enter git
name/email when just doing e.g. ./mk inject

a valid complaint, but their attitude kinda
stunk. oh well. this patch should satisfy them.

Signed-off-by: Leah Rowe <leah@libreboot.org>
2026-07-27 23:35:38 +01:00