only do if config=y. this reintroduces a hack that
i accidentally removed in the recent redesign.
grub has been changed to noconfig=y, and the files
for memdisk are now source from config/data/grub
Signed-off-by: Leah Rowe <leah@libreboot.org>
don't execute mkhelpers either
skip is fetched. this means that if a given
target says release=n, the corresponding source
won't be downloaded. if no targets specify that
source, then none will be.
Signed-off-by: Leah Rowe <leah@libreboot.org>
otherwise, dry builds are conducted, which pollutes
src tarballs.
this was a regression introduced by the recent
multi-tree-only design change. this should hopefully
be the only regression.
Signed-off-by: Leah Rowe <leah@libreboot.org>
we currently distinguish, by virtue of logic, multi-
and single-tree projects. this introduces a lot of
complexity, so the following patch has removed this
distinction. all single-tree projects are now multi
tree, but with only one tree.
other design changes:
config/git removed. rev/tree now handled with mkhelper
and target configs. this allows per-tree remote handling,
so we could (for example) add the mrchromebox coreboot
fork easily, for specific chromebook models.
config/project is now config/module/project. this
cleans up the main config/ directory.
cfgname variable: .config no longer hardcoded when
doing configs in projects. it is configurable with
this variable. if unset, the previous .cfg is used
noconfig variable: set this in target/mkhelper
configs, and config/module/project/tree/config/ is
unused; instead, make is called without config copying.
a "noconfig" placeholder is used. this enables cleaner
usage of previously single-tree projects in the new
multi-tree-only structure.
cfgvars: variables reinitialised in project config are
cleaned more reliably. in particular, several variables
e.g. autogenargs were not being reset between projects,
although the autogenargs variable is currently unused.
general cleanup has been conducted across the build
system, as part of this redesign. several parts of the
build system more over-engineered as a result of the
previous design, and the new design enabled a severe
reduction in sloccount (75 lines reduced in lbmk).
yes, this change *adds features* but there are fewer
lines of code than before. this is the best kind of
change. way better than the 3-line-diff. yes.
rev= and tree= are set more centrally in configs. the
mkhelper config can be used to set url/url_bkup, but
individual trees can override them.
configs have been cleaned up, with several variables
now much more heavily centralised. config/git/ was
used before to first download the bare repository, and
then the real clone was made with patches. this allows
git repositories to be cached for future re-builds.
with config/git/ gone, the download logic for projects
is more centrally implemented. a separate call to ./mk -f
is no longer performed, and in fact ./mk -f never needs
to be used anymore as a result. ./mk -f now is basically
the same thing as -b, just without any action performed.
this change will allow rapid expansion of the libreboot
project. i want to add hundreds of chromebooks to the
project, using mrchromebox, but the previous design did
not permit this. this change means that i can easily have
unlimited upstreams per project. coreboot will, in some
follow-up changes, have the following upstreams:
coreboot/default: coreboot.org
coreboot/fam15h: 15h.org fork
coreboot/chromebook: mrchromebox fork
this can now be done freely without massive changes to
the build system. under the previous design, i worked on
a now-abandoned patch to do N remotes per project, reading
repo links from a file. this meant that i'd have coreboot.org
first (main and backup), then mrchromebox. this meant that
lbmk would failover through to mrchromebox, wasting time
for the user.
this new design is much cleaner, and will enable the
project to be maintained much more easily.
Signed-off-by: Leah Rowe <leah@libreboot.org>
if_build / empty mode are a given here, since this
is a premake function which only executes if
the mode string is empty and/or if_build is empty
Signed-off-by: Leah Rowe <leah@libreboot.org>
note: mecleaner check removed in vendor.sh, because
it's already guaranteed to be fetched. the check will
never indicate failure, so we can just assume that
the me cleaner python script exists.
Signed-off-by: Leah Rowe <leah@libreboot.org>
ccache isn't used at all in any of the configs
ensuring that this remains the case is much
cleaner. coreboot will never enable it by default,
precisely because of how buggy it is.
Signed-off-by: Leah Rowe <leah@libreboot.org>
the modified/not message is pointless, because the
message indicating tarball rebuild will suffice
variable initialisation simplified (global newvar)
Signed-off-by: Leah Rowe <leah@libreboot.org>
-m src can skip building binaries
this is pointless. i always want them.
i won't use it, and i'm the only person
who will ever use ./mk release
i'm going to add a -t option in the future
to allow e.g. ./mk -t coreboot
this would do -f but create a tarball of
the source, versioned. e.g.
coreboot-libreboot-27.05_src.tar.xz
or something like that. this would allow
more granular control, if you just want to
get sources.
Signed-off-by: Leah Rowe <leah@libreboot.org>
this fixes a build issue i was having on ./mk release,
and it's also a preventative bug fix.
instead of forcing it to be enabled, we now force
it to be disabled. all current configs already disable
it, and disabled is the default.
just in case, disable it by force. i encountered build
errors on ./mk release, due to stale build artifacts.
i had no issues on normal lbmk.git, doing builds, but
./mk release builds everything in bulk. we want the
release build process to be as reliable as possible.
this won't actually affect build speed much, due to
lbmk's design (clean builds before running make).
work is needed upstream, to make ccache more reliable.
ccache is fine when you're re-building the same board
a lot, but there's just no way it can be used reliably
when building lots of very different boards, where the
code greatly differs in coreboot.
Signed-off-by: Leah Rowe <leah@libreboot.org>
when calling ./mk, or from PATH, an absolute path
is created to ./mk
this will likely be different than mk, but it might
be a different script. perhaps the operator is making
a copy of the mk script temporarily - obviously not
advised, no, but here we have a problem because then
lbmk is still running ./mk everywhere
run arg0 instead, now called "mk"
./mk is still hardcoded in release.sh, because we
do need to make sure we're using the right script
there
Signed-off-by: Leah Rowe <leah@libreboot.org>
e.g. biosutilities
the subshell screws up error handling. this
patch changes it to old behaviour.
some projects don't have makefiles. the
non-zero exit also prevents further call
to copy_elf when no binaries are created,
as in this example.
Signed-off-by: Leah Rowe <leah@libreboot.org>
This reverts commit cf079dbd17.
we don't need it anymore. we don't bother cleaning sources
for releases, because tehy're never dirtied. we build
using ./mk release which does everything fresh.
the git-clean feature was only used on ./mk -c, which was
removed because it's not needed for the same reason as
above. lbmk always cleans and re-builds everything when
metadata changes, otherwise storing builds out of tree
in a cache directory.
get rid of this dead code.
Signed-off-by: Leah Rowe <leah@libreboot.org>
the user never runs these. it's not needed. the design
of lbmk already cleans everything, or caches everything,
between builds. everything cached out of tree.
it's not expected to ever need to clean manually, so just
remove the option. knobs are for nobs.
releases don't need it either, because we tar everything
before building, thus eliminating all build artifacts.
we do this on a fresh copy of lbmk on ./mk release
Signed-off-by: Leah Rowe <leah@libreboot.org>
this was the previous behaviour, and prevents
single-tree builds from proceeding with
use of copy_elf
otherwise you get a bunch of build errors
Signed-off-by: Leah Rowe <leah@libreboot.org>
no point using distclean, because the context there
is providing clean sources for distribution, but we
use ./mk release which tars everything up before ever
running any build commands.
make-clean is enough
distclean is a stupid gnuism anyway, and most makefiles
that have it will just do the same as clean anyway
Signed-off-by: Leah Rowe <leah@libreboot.org>
Leah Rowe
Ronanand0