coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-11 14:02:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/nvmutil: use off_t for partsize (pread/pwrite)

Browse Source 
size_t can truncate on some platforms. it's best to use
the proper variable type (a cast is insufficient).

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-03-03 23:12:15 +00:00
parent ae080c35e4
commit 7b15b020b5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/nvmutil/nvmutil.c
+3 -3
View File
@@ -65,7 +65,7 @@ static void set_err(int);
static uint8_t buf[SIZE_8KB];
static uint16_t macbuf[3];
static size_t partsize;
static off_t partsize;
static int flags;
static int rfd;
@@ -250,7 +250,7 @@ read_gbe_part(int p, int invert)
for (retry = 0; retry < (int) MAX_RETRY_READ; retry++) {
rval = pread(fd, buf + (SIZE_4KB * (p ^ invert)),
SIZE_4KB, p * partsize);
SIZE_4KB, ((off_t ) p) * partsize);
if (valid_read(fname, rval,
(ssize_t) SIZE_4KB, retry, "pread")) {
@@ -582,7 +582,7 @@ write_gbe_part(int p)
swap(p); /* swap bytes on big-endian host CPUs */
if (pwrite(fd, buf + (SIZE_4KB * p),
SIZE_4KB, p * partsize) != (ssize_t) SIZE_4KB) {
SIZE_4KB, ((off_t) p) * partsize) != (ssize_t) SIZE_4KB) {
err(ECANCELED,
"Can't write %d b to '%s' p%d", SIZE_4KB, fname, p);
}