coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-11 14:02:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/nvmutil: cmd_swap(): write sequentually

Browse Source 
the current code writes part 1 first, and part 0 next,
on the disk, due to the way the swap works.

with this change, swap still swaps the two parts of the file,
on disk, but writes the new file sequentially.

this change might speed up i/o on the file system, on HDDs.
on SSDs, this change likely makes no difference at all.
This commit is contained in:
Leah Rowe
2023-01-28 20:27:24 +00:00
parent 7e3a73558e
commit 3e150bf303
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/nvmutil/nvmutil.c
+6 -1
View File
@@ -438,16 +438,21 @@ writeGbeFile(int *fd, const char *filename)
nw = 128;
for (p = 0; p < 2; p++) {
if (gbe[0] > gbe[1])
p ^= 1;
if (nvmPartModified[p]) {
printf("Part %d modified\n", p);
} else {
fprintf (stderr,
"Part %d NOT modified\n", p);
continue;
goto next_part;
}
if (pwrite((*fd), (uint8_t *) gbe[p], nw, p << 12) != nw)
err(errno, "%s", filename);
tw += nw;
next_part:
if (gbe[0] > gbe[1])
p ^= 1;
}
if (close((*fd)))
err(errno, "%s", filename);