mirror of
https://codeberg.org/libreboot/lbmk.git
synced 2026-07-11 05:52:36 +02:00
Leah Rowe
c716341c13
I realised that the Dell OptiPlex 3050 Micro has NVRAM available. Use that backend, and hardcode power_on_after_fail to Disable, which is already done in cmos.default. The Lenovo ThinkPad T480 currently has no option table in coreboot, besides the CBFS one. For this, the CBFS option table has been enabled, and the build system has been modified to insert a relevant config for power_on_after_fail. Nicholas Chin informs me that Kabylake generally has legacy NVRAM, so enabling it for the T480/T480s should work, but we'll need to use it in the future anyway; better to just use CBFS now. I *could* use the CBFS backend on 3050micro as well. Signed-off-by: Leah Rowe <leah@libreboot.org>
50 lines
2.0 KiB
Diff
50 lines
2.0 KiB
Diff
From 17c67799604e0e29192415e97293d71deb457cb2 Mon Sep 17 00:00:00 2001
|
|
From: Leah Rowe <info@minifree.org>
|
|
Date: Wed, 11 Dec 2024 01:06:01 +0000
|
|
Subject: [PATCH 29/40] dell/3050micro: disable nvme hotplug
|
|
|
|
in my testing, when running my 3050micro for a few days,
|
|
the nvme would sometimes randomly rename.
|
|
|
|
e.g. nvme0n1 renamed to nvme0n2
|
|
|
|
this might cause crashes in linux, if booting only from the
|
|
nvme. in my case, i was booting from mdraid (sata+nvme) and
|
|
every few days, the nvme would rename at least once, causing
|
|
my RAID to become unsynced. since i'm using RAID1, this was
|
|
OK and I could simply re-sync the array, but this is quite
|
|
precarious indeed. if you're using raid0, that will potentially
|
|
corrupt your RAID array indefinitely.
|
|
|
|
this same issue manifested on the T480/T480 thinkpads, and
|
|
S3 resume would break because of that, when booting from nvme,
|
|
because the nvme would be "unplugged" and appear to linux as a
|
|
new device (the one that you booted from).
|
|
|
|
the fix there was to disable hotplugging on that pci-e slot
|
|
for the nvme, so apply the same fix here for 3050 micro
|
|
|
|
Signed-off-by: Leah Rowe <leah@libreboot.org>
|
|
---
|
|
src/mainboard/dell/optiplex_3050/devicetree.cb | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/mainboard/dell/optiplex_3050/devicetree.cb b/src/mainboard/dell/optiplex_3050/devicetree.cb
|
|
index 0d2adff74a..829acacab3 100644
|
|
--- a/src/mainboard/dell/optiplex_3050/devicetree.cb
|
|
+++ b/src/mainboard/dell/optiplex_3050/devicetree.cb
|
|
@@ -44,7 +44,9 @@ chip soc/intel/skylake
|
|
register "PcieRpAdvancedErrorReporting[20]" = "1"
|
|
register "PcieRpLtrEnable[20]" = "true"
|
|
register "PcieRpClkSrcNumber[20]" = "3"
|
|
- register "PcieRpHotPlug[20]" = "1"
|
|
+# disable hotplug on nvme to prevent renaming e.g. nvme0n1 rename to nvme0n2,
|
|
+# which could cause crashes in linux if booting from nvme
|
|
+ register "PcieRpHotPlug[20]" = "0"
|
|
end
|
|
|
|
# Realtek LAN
|
|
--
|
|
2.47.3
|
|
|