mirror of
https://codeberg.org/libreboot/lbmk.git
synced 2026-07-11 05:52:36 +02:00
Leah Rowe
c716341c13
I realised that the Dell OptiPlex 3050 Micro has NVRAM available. Use that backend, and hardcode power_on_after_fail to Disable, which is already done in cmos.default. The Lenovo ThinkPad T480 currently has no option table in coreboot, besides the CBFS one. For this, the CBFS option table has been enabled, and the build system has been modified to insert a relevant config for power_on_after_fail. Nicholas Chin informs me that Kabylake generally has legacy NVRAM, so enabling it for the T480/T480s should work, but we'll need to use it in the future anyway; better to just use CBFS now. I *could* use the CBFS backend on 3050micro as well. Signed-off-by: Leah Rowe <leah@libreboot.org>
52 lines
1.6 KiB
Diff
52 lines
1.6 KiB
Diff
From 215661dbe631c21a2533cc93bdd1e9f82aa9601e Mon Sep 17 00:00:00 2001
|
|
From: Leah Rowe <info@minifree.org>
|
|
Date: Sat, 6 Apr 2024 01:22:47 +0100
|
|
Subject: [PATCH 13/40] nb/haswell: Fully disable iGPU when dGPU is used
|
|
|
|
My earlier patch disabled decode *and* disabled the iGPU itself, but
|
|
a subsequent revision disabled only VGA decode. Upon revisiting, I
|
|
found that, actually, yes, you also need to disable the iGPU entirely.
|
|
|
|
Tested on Dell 9020 SFF using broadwell MRC, with both iGPU and dGPU.
|
|
With this patch, the iGPU is completely disabled when you install a
|
|
graphics card, but the iGPU is available to use when no graphics card
|
|
is present.
|
|
|
|
For more context, see:
|
|
|
|
Author: Leah Rowe <info@minifree.org>
|
|
Date: Fri Feb 23 13:33:31 2024 +0000
|
|
|
|
nb/haswell: Disable iGPU when dGPU is used
|
|
|
|
And look at the Gerrit comments:
|
|
|
|
https://review.coreboot.org/c/coreboot/+/80717/
|
|
|
|
So, my original submission on change 80717 was actually correct.
|
|
This patch fixes the issue. I tested on iGPU and dGPU, with both
|
|
broadwell and haswell mrc.bin.
|
|
|
|
Signed-off-by: Leah Rowe <info@minifree.org>
|
|
---
|
|
src/northbridge/intel/haswell/gma.c | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c
|
|
index f7fad3183d..1b188e92e1 100644
|
|
--- a/src/northbridge/intel/haswell/gma.c
|
|
+++ b/src/northbridge/intel/haswell/gma.c
|
|
@@ -466,6 +466,9 @@ static void gma_func0_disable(struct device *dev)
|
|
{
|
|
/* Disable VGA decode */
|
|
pci_or_config16(pcidev_on_root(0, 0), GGC, 1 << 1);
|
|
+
|
|
+ /* Required or else the graphics card doesn't work */
|
|
+ dev->enabled = 0;
|
|
}
|
|
|
|
static struct device_operations gma_func0_ops = {
|
|
--
|
|
2.47.3
|
|
|