coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-11 05:52:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

lbutils/file: tidy up mkhtemp_tmpfile_linux

Browse Source 
make failure more obvious. no behavioural change.

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-04-02 22:11:50 +01:00
parent 7eecc42b92
commit fc3c7b9c3e
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/libreboot-utils/lib/mkhtemp.c
+15 -14
View File
@@ -694,26 +694,27 @@ mkhtemp_tmpfile_linux(int dirfd,
st_dir_first) < 0) st_dir_first) < 0)
goto err; goto err;
if (linkat(tmpfd, "", dirfd, fname_copy, AT_EMPTY_PATH) == 0) { if (linkat(tmpfd, "", dirfd,
fname_copy, AT_EMPTY_PATH) == -1) {
linked = 1; /* file created */ if (errno == EEXIST)
continue; /* retry on collision */
/* TODO: potential fd leak here. else
* probably should only set *fd on successful
* return from this function (see below)
*/
if (fd_verify_dir_identity(dirfd, st_dir_first) < 0 ||
fstat(*fd = tmpfd, st) < 0 ||
secure_file(fd, st, st, O_APPEND, 1, 1, 0600) < 0)
goto err; goto err;
goto out;
} }
if (errno != EEXIST) linked = 1; /* file created */
/* TODO: potential fd leak here.
* probably should only set *fd on successful
* return from this function (see below)
*/
if (fd_verify_dir_identity(dirfd, st_dir_first) < 0 ||
fstat(*fd = tmpfd, st) < 0 ||
secure_file(fd, st, st, O_APPEND, 1, 1, 0600) < 0)
goto err; goto err;
/* retry on collision */ goto out;
} }
errno = EEXIST; errno = EEXIST;