coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-19 00:03:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

roms: rename x variable to it in for loop

Browse Source 
there are two for loops that use x as a variable anme,
and an idiosyncrasy of certain sh implementations is
that these become global;

the result in this case was that when you finish building
every target in "./build roms", it would print "libgfxinit"
repeatedly, comma separated, instead of a comma-separated
list of the targets that were built.

work around it by renaming the variable in one of the loops.

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2024-06-17 01:05:28 +01:00
parent 58a451865b
commit f928ac5c70
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/roms
+2 -2
View File
@@ -173,8 +173,8 @@ build_board()
{ {
x_ rm -Rf "$romdir" x_ rm -Rf "$romdir"
for x in "normal" "vgarom" "libgfxinit"; do for it in "normal" "vgarom" "libgfxinit"; do
initmode="$x" initmode="$it"
hmode="vesafb" hmode="vesafb"
[ "$initmode" = "vgarom" ] || hmode="corebootfb" [ "$initmode" = "vgarom" ] || hmode="corebootfb"
modes="$hmode txtmode" modes="$hmode txtmode"