coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-17 18:34:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/nvmutil: remove cmd_brick

Browse Source 
this is an extremely dangerous feature, and serves
no purpose to the user.

this change is part of a series of extreme safety
improvements, part of a larger nvmutil audit.

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-03-09 02:23:22 +00:00
parent 0c64907a9e
commit aeb076b30e
1 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/nvmutil/nvmutil.c
+2 -22
View File
@@ -85,7 +85,6 @@ static void write_mac_part(size_t partnum);
static void cmd_dump(void); static void cmd_dump(void);
static void print_mac_from_nvm(size_t partnum); static void print_mac_from_nvm(size_t partnum);
static void hexdump(size_t partnum); static void hexdump(size_t partnum);
static void cmd_brick(void);
static void write_gbe_file(void); static void write_gbe_file(void);
static void override_part_modified(void); static void override_part_modified(void);
static void set_checksum(size_t part); static void set_checksum(size_t part);
@@ -201,7 +200,6 @@ enum {
CMD_SETMAC, CMD_SETMAC,
CMD_SWAP, CMD_SWAP,
CMD_COPY, CMD_COPY,
CMD_BRICK,
}; };
/* /*
@@ -282,15 +280,6 @@ static const struct commands command[] = {
ARG_PART, ARG_PART,
CHECKSUM_READ, SKIP_CHECKSUM_WRITE, CHECKSUM_READ, SKIP_CHECKSUM_WRITE,
GBE_PART_SIZE }, GBE_PART_SIZE },
/*
* The non-target part will not be read.
*/
{ CMD_BRICK, "brick", cmd_brick, ARGC_4,
NO_INVERT, SET_MOD_OFF,
ARG_PART,
CHECKSUM_READ, SKIP_CHECKSUM_WRITE,
NVM_SIZE },
}; };
#define MAX_CMD_LEN 50 #define MAX_CMD_LEN 50
@@ -1035,13 +1024,6 @@ hexdump(size_t partnum)
} }
} }
static void
cmd_brick(void)
{
uint16_t checksum_word = nvm_word(NVM_CHECKSUM_WORD, part);
set_nvm_word(NVM_CHECKSUM_WORD, part, checksum_word ^ 1);
}
static void static void
write_gbe_file(void) write_gbe_file(void)
{ {
@@ -1342,10 +1324,8 @@ usage(uint8_t usage_exit)
"\t%s FILE # same as setmac without [MAC]\n" "\t%s FILE # same as setmac without [MAC]\n"
"\t%s FILE setmac [MAC]\n" "\t%s FILE setmac [MAC]\n"
"\t%s FILE swap\n" "\t%s FILE swap\n"
"\t%s FILE copy 0|1\n" "\t%s FILE copy 0|1\n",
"\t%s FILE brick 0|1\n" util, util, util, util, util);
"\t%s FILE setchecksum 0|1\n",
util, util, util, util, util, util, util);
if (usage_exit) if (usage_exit)
err(ECANCELED, "Too few arguments"); err(ECANCELED, "Too few arguments");