scripts: better handling of printf: stdout/stderr

in some cases, messages that should be considered errors
or warnings, were being written to the standard output,
rather than written as error messages.

also: one or two printf statements should specifically
avoid printing errors (to any file); in these cases,
stdout has been redirected to /dev/null

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2023-09-09 23:15:17 +01:00
parent b78009e28a
commit 84bf47b5b9
6 changed files with 10 additions and 9 deletions
+2 -1
View File
@@ -38,7 +38,8 @@ detect_firmware()
[ "${CONFIG_INCLUDE_SMSC_SCH5545_EC_FW}" = "y" ] && \
needs="${needs} SCH5545EC"
[ -z ${needs+x} ] && \
printf "No binary blobs needed for this board\n" && \
printf "No binary blobs needed for board: %s\n" "${board}" \
1>&2 && \
return 1
printf "Firmware needed for board '%s':\n%s\n" "${board}" "${needs}"
}
+2 -2
View File
@@ -62,11 +62,11 @@ check_existing()
{
[ -f "${_mrc_complete}" ] || \
return 0
printf 'found existing mrc.bin\n'
printf "found existing mrc.bin\n" 1>&2
[ "$(sha512sum "${_mrc_complete}" | awk '{print $1}')" \
= "${_mrc_complete_hash}" ] && \
return 1
printf 'hashes did not match, starting over\n'
printf "hashes did not match, starting over\n" 1>&2
}
build_dependencies()