scripts: better handling of printf: stdout/stderr

in some cases, messages that should be considered errors
or warnings, were being written to the standard output,
rather than written as error messages.

also: one or two printf statements should specifically
avoid printing errors (to any file); in these cases,
stdout has been redirected to /dev/null

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2023-09-09 23:15:17 +01:00
parent b78009e28a
commit 84bf47b5b9
6 changed files with 10 additions and 9 deletions
+1 -1
View File
@@ -22,7 +22,7 @@ listitems()
# -e used because this is for files *or* directories
[ -e "${x}" ] || continue
[ "${x##*/}" = "build.list" ] && continue
printf "%s\n" "${x##*/}"
printf "%s\n" "${x##*/}" 2>/dev/null
items=0
done
return ${items}
+3 -3
View File
@@ -191,9 +191,9 @@ strip_ucode()
"${cbfstool}" "${_newrom_b}" remove -n \
cpu_microcode_blob.bin 2>/dev/null || microcode_present="n"
if [ "${microcode_present}" = "n" ]; then
printf "REMARK: '%s' already lacks microcode\n" \
"${romfile}"
printf "Renaming default ROM file instead.\n"
printf "REMARK: '%s' already lacks microcode\n" "${romfile}" \
1>&2
printf "Renaming default ROM file instead.\n" 1>&2
mv "${romfile}" "${_newrom_b}" || \
err "strip_rom_image: can't rename no-u ${romfile}"
fi