Do not rely on bashisms and behaviour undefined by the POSIX specification. Part 2

Signed-off-by: Ferass 'Vitali64' EL HAFIDI <vitali64pmemail@protonmail.com>
This commit is contained in:
Ferass 'Vitali64' EL HAFIDI
2022-12-28 19:29:18 +01:00
committed by Leah Rowe
parent f787044642
commit 7f5dfebf7d
14 changed files with 42 additions and 37 deletions
+7 -6
View File
@@ -1,9 +1,10 @@
#!/usr/bin/env bash
#!/usr/bin/env sh
# helper script: download coreboot
#
# Copyright (C) 2014, 2015, 2016, 2020, 2021 Leah Rowe <info@minifree.org>
# Copyright (C) 2022 Alper Nebi Yasak <alpernebiyasak@gmail.com>
# Copyright (C) 2022 Ferass El Hafidi <vitali64pmemail@protonmail.com>
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -52,17 +53,17 @@ usage()
# In this script, set -u is used to check for undefined variables, and
# the test command doesn't do any lazy evaluation, so we can't use
# a syntax like that: [ $# -eq 1 -a "$1" == "--help" ].
# a syntax like that: [ $# -eq 1 -a "$1" = "--help" ].
if [ $# -eq 1 ] && [ "$1" == "--help" ] ; then
if [ $# -eq 1 ] && [ "$1" = "--help" ] ; then
usage
exit 0
elif [ $# -eq 1 ] && [ "$1" == "--list-boards" ] ; then
elif [ $# -eq 1 ] && [ "$1" = "--list-boards" ] ; then
list_supported_boards
exit 0
fi
[[ -f build_error ]] && rm -f build_error
[ -f build_error ] && rm -f build_error
rm -f resources/coreboot/*/seen
@@ -90,7 +91,7 @@ downloadfor() {
fi
# This is to override $cbrevision and $cbtree
source "resources/coreboot/${board}/board.cfg" || touch ../build_error
. "resources/coreboot/${board}/board.cfg" || touch ../build_error
if [ -f build_error ]; then
printf "ERROR: download/coreboot: problem sourcing %s/board.cfg\n" "${board}"
return 1