coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-16 13:16:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

cleanup (fix potential overflow in mkstemp)

Browse Source 
Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-03-16 21:17:25 +00:00
parent 47a654a870
commit 6e6ab09cb0
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/nvmutil/nvmutil.c
+2 -3
View File
@@ -3039,10 +3039,9 @@ x_i_mkstemp(char *template)
char *p; char *p;
char ch[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"; char ch[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
unsigned long chlen; unsigned long r = rlong();
len = xstrxlen(template, PATH_LEN); len = xstrxlen(template, PATH_LEN);
chlen = xstrxlen(ch, 100);
/* find trailing XXXXXX */ /* find trailing XXXXXX */
if (len < 6) if (len < 6)
@@ -3053,7 +3052,7 @@ x_i_mkstemp(char *template)
for (i = 0; i < 100; i++) { for (i = 0; i < 100; i++) {
for (j = 0; j < 6; j++) for (j = 0; j < 6; j++)
p[j] = ch[rlong() % chlen]; p[j] = ch[r % (sizeof(ch) - 1)];
fd = open(template, O_RDWR | O_CREAT | O_EXCL, 0600); fd = open(template, O_RDWR | O_CREAT | O_EXCL, 0600);