mirror of
https://codeberg.org/libreboot/lbmk.git
synced 2026-07-16 03:25:25 +02:00
lbmk: don't use status for unconditional returns
in cases where lbmk must always return from a function, there are some cases where it relies on non-zero exit status, which in practise is always the case, but may change in the future if the relevant part is modified e.g. do_something && return 0 the proper form is: do_something return 0 also do this for unconditional exits Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Vendored
+4
-2
@@ -140,8 +140,10 @@ vendor_checksum()
|
||||
|
||||
mkdirs()
|
||||
{
|
||||
[ -f "${1}" ] && \
|
||||
printf "mkdirs ${1} ${2}: already downloaded\n" 1>&2 && return 1
|
||||
if [ -f "${1}" ]; then
|
||||
printf "mkdirs ${1} ${2}: already downloaded\n" 1>&2
|
||||
return 1
|
||||
fi
|
||||
mkdir -p "${1%/*}" || err "mkdirs: !mkdir -p ${1%/*}"
|
||||
x_ rm -Rf "${appdir}"
|
||||
x_ mkdir -p "${appdir}/"
|
||||
|
||||
Vendored
+4
-2
@@ -14,8 +14,10 @@ eval "$(setvars "" archive rom modifygbe nukemode release new_mac)"
|
||||
main()
|
||||
{
|
||||
[ $# -lt 1 ] && err "No options specified."
|
||||
[ "${1}" = "listboards" ] && \
|
||||
items config/coreboot && exit 0
|
||||
if [ "${1}" = "listboards" ]; then
|
||||
items config/coreboot || :
|
||||
exit 0
|
||||
fi
|
||||
|
||||
archive="${1}"
|
||||
|
||||
|
||||
Reference in New Issue
Block a user