coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-14 15:29:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix several shellcheck warnings

Browse Source 
lbmk didn't quote certain arguments in commands, or
used ! -z instead of -n, things like that. simple fixes.

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2023-12-16 07:56:26 +00:00
parent 54ca5f24d2
commit 1eb4df6748
9 changed files with 43 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/err.sh
+6 -6
View File
@@ -36,23 +36,23 @@ git_err()
check_project()
{
read projectname < projectname || :
read -r projectname < projectname || :
[ ! -f version ] || read version < version || :
[ ! -f version ] || read -r version < version || :
version_="${version}"
[ ! -e ".git" ] || version="$(git describe --tags HEAD 2>&1)" || \
version="git-$(git rev-parse HEAD 2>&1)" || version="${version_}"
[ ! -f versiondate ] || read versiondate < versiondate || :
[ ! -f versiondate ] || read -r versiondate < versiondate || :
versiondate_="${versiondate}"
[ ! -e ".git" ] || versiondate="$(git show --no-patch --no-notes \
--pretty='%ct' HEAD)" || versiondate="${versiondate_}"
[ ! -z ${versiondate} ] || fail "Unknown version date" || \
[ -n "${versiondate}" ] || fail "Unknown version date" || \
err "Unknown version date"
[ ! -z ${version} ] || fail "Unknown version" || \
[ -n "${version}" ] || fail "Unknown version" || \
err "Unknown version"
[ ! -z ${projectname} ] || fail "Unknown project" || \
[ -n "${projectname}" ] || fail "Unknown project" || \
err "Unknown project"
xx_ printf "%s\n" "${version}" > version || \