mirror of
https://codeberg.org/libreboot/lbmk.git
synced 2026-07-14 23:39:33 +02:00
fix several shellcheck warnings
lbmk didn't quote certain arguments in commands, or used ! -z instead of -n, things like that. simple fixes. Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
+6
-6
@@ -36,23 +36,23 @@ git_err()
|
||||
|
||||
check_project()
|
||||
{
|
||||
read projectname < projectname || :
|
||||
read -r projectname < projectname || :
|
||||
|
||||
[ ! -f version ] || read version < version || :
|
||||
[ ! -f version ] || read -r version < version || :
|
||||
version_="${version}"
|
||||
[ ! -e ".git" ] || version="$(git describe --tags HEAD 2>&1)" || \
|
||||
version="git-$(git rev-parse HEAD 2>&1)" || version="${version_}"
|
||||
|
||||
[ ! -f versiondate ] || read versiondate < versiondate || :
|
||||
[ ! -f versiondate ] || read -r versiondate < versiondate || :
|
||||
versiondate_="${versiondate}"
|
||||
[ ! -e ".git" ] || versiondate="$(git show --no-patch --no-notes \
|
||||
--pretty='%ct' HEAD)" || versiondate="${versiondate_}"
|
||||
|
||||
[ ! -z ${versiondate} ] || fail "Unknown version date" || \
|
||||
[ -n "${versiondate}" ] || fail "Unknown version date" || \
|
||||
err "Unknown version date"
|
||||
[ ! -z ${version} ] || fail "Unknown version" || \
|
||||
[ -n "${version}" ] || fail "Unknown version" || \
|
||||
err "Unknown version"
|
||||
[ ! -z ${projectname} ] || fail "Unknown project" || \
|
||||
[ -n "${projectname}" ] || fail "Unknown project" || \
|
||||
err "Unknown project"
|
||||
|
||||
xx_ printf "%s\n" "${version}" > version || \
|
||||
|
||||
+1
-1
@@ -123,7 +123,7 @@ clone_project()
|
||||
[ "${patchfail}" = "y" ] && err "PATCH FAIL"
|
||||
|
||||
x_ rm -Rf "${loc}"
|
||||
[ "${loc}" = "${loc%/*}" ] || x_ mkdir -p ${loc%/*}
|
||||
[ "${loc}" = "${loc%/*}" ] || x_ mkdir -p "${loc%/*}"
|
||||
mv "${tmp_git_dir}" "${loc}" || \
|
||||
err "clone_project: !mv ${tmp_git_dir} ${loc}"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user