coja/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-07-11 14:02:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

init.sh: don't use eval to read version files

Browse Source 
it's not necessary, and was the cause of a recent issue,
which i mitigated, but why mitigate it?

prevent bugs. don't use eval unless absolutely necessary.

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2025-04-29 12:01:13 +01:00
parent 3045079947
commit 093a86d9c0
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/init.sh
+2 -3
View File
@@ -161,9 +161,8 @@ xbmk_set_env()
xbmk_set_version()
{
for fv in version versiondate; do
eval "[ ! -f \"\.$fv\" ] || read -r $fv < \"\.$fv\" || :"
done
[ ! -f ".version" ] || read -r version < ".version" || :; :
[ ! -f ".versiondate" ] || read -r versiondate < ".versiondate" || :; :
[ -e ".git" ] || [ -f ".version" ] || printf "unknown\n" > ".version" \
|| $err "Cannot generate unknown .version file"