From 058a70a16e4a1172c0eadacb564ee864c5b61ae7 Mon Sep 17 00:00:00 2001
From: Leah Rowe <leah@libreboot.org>
Date: Thu, 17 Sep 2026 10:45:16 +0100
Subject: [PATCH] pcsx-redux: check dry build in mkhelper

Signed-off-by: Leah Rowe <leah@libreboot.org>
---
 config/data/pcsx-redux/mkhelper.cfg | 3 ++-
 config/pcsx-redux/target.cfg        | 1 -
 include/fw/rom.sh                   | 3 ---
 include/lib.sh                      | 2 +-
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/config/data/pcsx-redux/mkhelper.cfg b/config/data/pcsx-redux/mkhelper.cfg
index 6ad20de5..d7369797 100644
--- a/config/data/pcsx-redux/mkhelper.cfg
+++ b/config/data/pcsx-redux/mkhelper.cfg
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-postmake="copyps1bios"
+mkhelper="$if_not_dry_build copyps1bios"
+postmake="$if_not_dry_build copyps1bios"
diff --git a/config/pcsx-redux/target.cfg b/config/pcsx-redux/target.cfg
index 36e2a055..b30c144f 100644
--- a/config/pcsx-redux/target.cfg
+++ b/config/pcsx-redux/target.cfg
@@ -2,4 +2,3 @@
 
 makeargs="-f lbmkbofhmakefile"
 cleanargs="-f lbmkbofhmakefile"
-mkhelper="copyps1bios"
diff --git a/include/fw/rom.sh b/include/fw/rom.sh
index b6c98fbf..0b3a92dd 100644
--- a/include/fw/rom.sh
+++ b/include/fw/rom.sh
@@ -25,9 +25,6 @@ buildser()
 
 copyps1bios()
 {
-	$if_dry_build \
-		return 0
-
 	remkdir "bin/playstation"
 	x_ cp src/pcsx-redux/src/mips/openbios/openbios.bin bin/playstation
 
diff --git a/include/lib.sh b/include/lib.sh
index 74b75283..c8b07b60 100644
--- a/include/lib.sh
+++ b/include/lib.sh
@@ -8,7 +8,7 @@
 cbfstool="elf/coreboot/default/cbfstool"
 rmodtool="elf/coreboot/default/rmodtool"
 
-build_sbase="[ ! -f \"\$sha512sum\" ] && x_ make -C util/sbase" # macro!
+build_sbase="[ ! -f \"\$sha512sum\" ] && x_ make -C util/sbase"
 
 newvar()
 {